Skip to content

Fix container stats build break #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realrajaryan merged 1 commit into from
Nov 19, 2025
Merged

Fix container stats build break #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions Tests/CLITests/Subcommands/Containers/TestCLIStats.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class TestCLIStatsCommand: CLITest {
}
try waitForContainerRunning(name)

let (output, error, status) = try run(arguments: [
let (data, _, error, status) = try run(arguments: [
"stats",
"--format", "json",
"--no-stream",
Expand All @@ -42,12 +42,8 @@ class TestCLIStatsCommand: CLITest {

try #require(status == 0, "stats command should succeed, error: \(error)")

guard let jsonData = output.data(using: .utf8) else {
throw CLIError.invalidOutput("stats output invalid")
}

let decoder = JSONDecoder()
let stats = try decoder.decode([ContainerStats].self, from: jsonData)
let stats = try decoder.decode([ContainerStats].self, from: data)

#expect(stats.count == 1, "expected stats for one container")
#expect(stats[0].id == name, "container ID should match")
Expand All @@ -67,7 +63,7 @@ class TestCLIStatsCommand: CLITest {
try waitForContainerRunning(name)

// Get stats in table format
let (output, _, status) = try run(arguments: [
let (_, output, _, status) = try run(arguments: [
"stats",
"--no-stream",
name,
Expand Down Expand Up @@ -111,7 +107,7 @@ class TestCLIStatsCommand: CLITest {
try waitForContainerRunning(name)

// Get stats in table format
let (output, _, status) = try run(arguments: [
let (_, output, _, status) = try run(arguments: [
"stats",
"--no-stream",
name,
Expand Down Expand Up @@ -157,7 +153,7 @@ class TestCLIStatsCommand: CLITest {
try waitForContainerRunning(name)

// Get stats in table format
let (output, error, status) = try run(arguments: [
let (_, output, error, status) = try run(arguments: [
"stats",
"--no-stream",
name,
Expand Down Expand Up @@ -187,19 +183,15 @@ class TestCLIStatsCommand: CLITest {
try waitForContainerRunning(name2)

// Get stats for all containers (no name specified)
let (output, error, status) = try run(arguments: [
let (data, _, error, status) = try run(arguments: [
"stats",
"--format", "json",
"--no-stream",
])

try #require(status == 0, "stats command should succeed, error: \(error)")

guard let jsonData = output.data(using: .utf8) else {
throw CLIError.invalidOutput("stats output invalid")
}

let stats = try JSONDecoder().decode([ContainerStats].self, from: jsonData)
let stats = try JSONDecoder().decode([ContainerStats].self, from: data)

// Should have stats for both containers
try #require(stats.count >= 2, "should have stats for at least 2 containers")
Expand All @@ -212,7 +204,7 @@ class TestCLIStatsCommand: CLITest {

@Test func testStatsNonExistentContainer() throws {
#expect(throws: Never.self, "expected stats to fail for non-existent container") {
let (_, _, status) = try run(arguments: [
let (_, _, _, status) = try run(arguments: [
"stats",
"--no-stream",
"nonexistent-container-xyz",
Expand Down