Skip to content

Fix incorrect creationDate for networks. #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jglogan merged 1 commit into from
Dec 2, 2025
Merged

Fix incorrect creationDate for networks. #926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Sources/Services/ContainerAPIService/Networks/NetworksService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,16 @@ public actor NetworksService {

let client = NetworkClient(id: configuration.id)
let networkState = try await client.state()
networkStates[configuration.id] = networkState

// FIXME: Temporary workaround for persisted configuration being overwritten
// by what comes back from the network helper, which messes up creationDate.
switch networkState {
case .created(_):
networkStates[configuration.id] = NetworkState.created(configuration)
case .running(_, let status):
networkStates[configuration.id] = NetworkState.running(configuration, status)
}

guard case .running = networkState else {
log.error(
"network failed to start",
Expand Down