Enable strict concurrency checking in CI #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@swift-server-bot add to allowlist |
Member
|
@swift-server-bot test this please |
Member
|
Hmm seems CI is not triggering, but this is LGTM -- let's fix CI so we get a run of it in all configurations and merge if good. |
ktoso
approved these changes
Aug 14, 2023
Member
|
@swift-server-bot test this please |
Member
|
Thank you @yim-lee and @czechboy0 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To help avoid concurrency bugs, enabled complete concurrency checking in CI.
Added the compiler flag to the docker-compose scripts, and verified that currently there are no warnings with this flag enabled.
Separately, it might make sense to enable warnings-as-errors on this repo to help avoid new warnings.
Test Plan
Verified locally that the repo produces no concurrency warnings.