Skip to content

Rsta update #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2017
Merged

Rsta update #6022

merged 3 commits into from
Mar 1, 2017

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 27, 2017

Alternative to #5990 / #5960

this one, compared to #5990, use a DocumentListener to update the Undo/Redo menu items each time the document changes or another tab is selected.

pro

  • simpler implementation
  • localization is done using the IDE resources (it could be translated through transifex and we can add new languages without depending on RSTA resources)

cons

  • it requires some workarounds because RSTA doesn't seems to always fire DocumentChanged events, see 18a57c2
  • we lose the "presentation" labels for Undo/Redo, because RSTA doesn't export the method to get them. Anyway, until now I've only seen "Undo"/"Redo" or "Cannot Undo"/"Cannot Redo", so probably just disabling the menu item is enough.

/cc @matthijskooijman

@mastrolinux mastrolinux added the in progress Work on this item is in progress label Feb 27, 2017
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-656-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-656-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-656-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-656-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-656-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@cmaglie cmaglie modified the milestone: Release 1.8.2 Feb 28, 2017
@cmaglie cmaglie added the Component: IDE user interface The Arduino IDE's user interface label Feb 28, 2017
cmaglie and others added 3 commits March 1, 2017 10:29
@cmaglie
Removed the need for get/setUndoManager()
38c811e 
This dramatically simplifies undo/redo handling and allows to use
unpatched RSyntaxTextArea library.
@matthijskooijman @cmaglie
Update RSyntaxTextArea to 2.6.1
328be09 
This imports the unmodified upstream version of RSTA from
http://repo1.maven.org/maven2/com/fifesoft/rsyntaxtextarea/2.6.1/rsyntaxtextarea-2.6.1.jar
since the Arduino-specific changes are no longer required.

This fixes arduino#5888
@cmaglie
Fixed regression tests on Indent/Unindent and Comment/Uncomment actions
c649eaa 
RSTA for some reason doesn't fire update signals on DocumentListeners.
@cmaglie cmaglie merged commit 1f35bfc into arduino:master Mar 1, 2017
@mastrolinux mastrolinux removed the in progress Work on this item is in progress label Mar 1, 2017
This was referenced Mar 1, 2017
Closed
Closed
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-657-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-657-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-657-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-657-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6022-BUILD-657-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

facchinm referenced this pull request in arduino/RSyntaxTextArea Mar 1, 2017
@facchinm
Expose the underlying undomanager to fit Arduino IDE needs
b6f31ca
@per1234 per1234 mentioned this pull request Jun 5, 2017
Open
@per1234 per1234 mentioned this pull request Jul 4, 2017
Closed
@cmaglie cmaglie deleted the rsta-update branch July 6, 2017 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Milestone
Release 1.8.2
Development

Successfully merging this pull request may close these issues.
4 participants
@cmaglie @ArduinoBot @mastrolinux @matthijskooijman