Skip to content

SocketWrapper library: MbedClient.setTimeout shadows Stream.setTimeout #728

Closed
@JAndrassy

Description

@JAndrassy
Contributor

MbedClient has setTimeout instead of setConnectionTimeout. setTimeout shadows Stream.setTimeout

Activity

changed the title [-]`MbedClient.setTimeout` shadows `Stream.setTimeout`[/-] [+]SocketWrapper libray: `MbedClient.setTimeout` shadows `Stream.setTimeout`[/+] on Sep 23, 2023
changed the title [-]SocketWrapper libray: `MbedClient.setTimeout` shadows `Stream.setTimeout`[/-] [+]SocketWrapper library: `MbedClient.setTimeout` shadows `Stream.setTimeout`[/+] on Sep 23, 2023
JAndrassy

JAndrassy commented on Nov 22, 2023

@JAndrassy
ContributorAuthor

Meanwhile I tested this timeout and it doesn't work for connect. It is not possible to do timeout on connect with Mbed.

I would recommend to rename to function to SetSocketTimeout

pennam

pennam commented on Nov 22, 2023

@pennam
Contributor

Meanwhile I tested this timeout and it doesn't work for connect. It is not possible to do timeout on connect with Mbed.

I've not tested it, but i think this is the reason ARMmbed/mbed-os#13056 (comment)

I would recommend to rename to function to SetSocketTimeout

Got it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @JAndrassy@pennam

      Issue actions

        SocketWrapper library: `MbedClient.setTimeout` shadows `Stream.setTimeout` · Issue #728 · arduino/ArduinoCore-mbed