Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 15, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    This PR removes the dependency from go.rice library and replaces it with the embed feature -> https://pkg.go.dev/embed
  • What is the current behavior?
    No changes in behavior.

  • Does this PR introduce a breaking change
    No

@cmaglie cmaglie merged commit 6c3c864 into arduino:master Oct 18, 2021
@cmaglie cmaglie deleted the drop_gorice_lib branch October 18, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants