Skip to content

ci: drop deprecated golint#41

Merged
igorpecovnik merged 1 commit intoarmbian:masterfrom
OpenSource-YYT:fix/ci-drop-deprecated-golint
Apr 14, 2026
Merged

ci: drop deprecated golint#41
igorpecovnik merged 1 commit intoarmbian:masterfrom
OpenSource-YYT:fix/ci-drop-deprecated-golint

Conversation

@SuperKali
Copy link
Copy Markdown
Member

CI on master has been failing since the runner moved to Go 1.25:

x/tools@v0.17.0/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta

That comes from go install golang.org/x/lint/golint, which drags in an old x/tools that doesn't build on Go 1.25 anymore (see golang/go#74462). golint itself has been archived since 2021 and won't get a new release, so pinning won't help either.

Easiest thing is to just drop it — go vet already runs and covers most of what golint flagged. If you want a proper modern linter later, staticcheck slots in cleanly.

Reference failing run: https://github.com/armbian/armbian-router/actions/runs/24421454847/job/71344499583

golint has been archived since 2021; the version resolved here pulls
golang.org/x/tools@v0.17.0 which no longer builds with Go 1.25
(golang/go#74462). go vet already runs for the same lint surface.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Warning

Rate limit exceeded

@SuperKali has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 17 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 17 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6153a0ae-cc27-4d26-948a-93e7409dfbd9

📥 Commits

Reviewing files that changed from the base of the PR and between 040dccc and 4ba0e42.

📒 Files selected for processing (1)
  • .github/workflows/main.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@igorpecovnik igorpecovnik merged commit a78ce33 into armbian:master Apr 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants