Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
rpardini
reviewed
Nov 9, 2025
rpardini
reviewed
Nov 9, 2025
ec115aa to
74feffa
Compare
74feffa to
2e70a53
Compare
2e70a53 to
78f2c17
Compare
Grippy98
reviewed
Dec 1, 2025
Grippy98
reviewed
Dec 1, 2025
78f2c17 to
292871e
Compare
rpardini
requested changes
Dec 29, 2025
Member
rpardini
left a comment
There was a problem hiding this comment.
=m and =y stuff is inconsistent. not what we want.
292871e to
398bcb6
Compare
Collaborator
|
My opinion remains that automation should allow both m or y. That is, the maintainer chooses.
So my Q here is, why was it changed in an ostensibly automated process.
The last bug I heard of had the opposite effect, inappropriately promoting =y. And I filed a PR to fix that. #9136
Sent from myPhone.On Dec 30, 2025, at 4:30 AM, Ricardo Pardini ***@***.***> wrote:
@rpardini commented on this pull request.
In config/kernel/linux-rockchip-edge.config:
@@ -1617,24 +1613,20 @@ CONFIG_MUX_MMIO=m
CONFIG_MOST=m
CONFIG_VALIDATE_FS_PARSER=y
CONFIG_EXT2_FS=y
-CONFIG_EXT3_FS=y
-CONFIG_EXT3_FS_POSIX_ACL=y
-CONFIG_EXT3_FS_SECURITY=y
+CONFIG_EXT4_FS=m
Agree -- another reason to just have opts_y+=("EXT4_FS") and stop having armbian-kernel.sh be inconsistent. @tabrisnet ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
You insist on missing the point, @tabrisnet. It's due to your "oh but the .config can have =y for something that is default =m" (which is wrong, inconsistent, causes problems both ways, and brings zero real benefit) that we have ext4=m by default. It should be =y. If your specific family needs =m, opt-out of the defaults. End of story. |
398bcb6 to
f83f470
Compare
rpardini
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite kernel configs
What this PR does
./compile.sh rewrite-kernel-configfor each scheduled (family, branch) and aggregates all changes into one PR.How it was produced
This PR is produced from this GHA script.
./compile.sh inventory-boards(deduped, sanitized).rewrite-kernel-configper matrix.Review tips
Files changed
Files: 64 • Lines: +938 / -2056 (Δ -1118)