desktops: suppress dpkg conffile prompt on install (non-interactive)#856
desktops: suppress dpkg conffile prompt on install (non-interactive)#856igorpecovnik merged 1 commit intomainfrom
Conversation
Symptom: during `module_desktops install` on a system that had
previously imported a chromium conffile from the package (e.g.
/etc/chromium/master_preferences), the install stops with:
Configuration file '/etc/chromium/master_preferences'
==> File on system created by you or by a script.
==> File also in package provided by package maintainer.
What would you like to do about it? ...
The install path was already passing --force-confold, but dpkg
still prompts when BOTH the user's file and the package's new
version differ from the original (exactly our case with the
browser-branding overlay in #854: we ship a
master_preferences via overlay and the chromium .deb ships its
own updated one).
Fix: add --force-confdef alongside --force-confold on every
pkg_install call, and set DEBIAN_FRONTEND=noninteractive for the
install branch so apt itself doesn't open a TUI. With both flags,
dpkg silently takes the default action (= keep local) on every
conffile it can't auto-merge.
Six pkg_install calls updated — desktop packages, display manager,
armbian-plymouth-theme, and the upgrade-tier path.
End-user effect: `armbian-config --api module_desktops install
de=... tier=...` now runs to completion without blocking on
conffile prompts, regardless of what's already on the system.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 40 minutes and 23 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
On a system that previously imported a chromium conffile (e.g. `/etc/chromium/master_preferences`) from the package, `module_desktops install` blocks at:
```
Configuration file '/etc/chromium/master_preferences'
==> File on system created by you or by a script.
==> File also in package provided by package maintainer.
What would you like to do about it? ...
```
The install path was already passing `--force-confold`, but that alone doesn't suppress the prompt when both the user's file and the package's new version differ from the original — exactly our case with the browser-branding overlay in #854 (overlay writes `master_preferences`, chromium .deb also ships an updated version).
Fix
6 `pkg_install` call sites updated — desktop packages, display manager, `armbian-plymouth-theme`, and the upgrade-tier path (`_module_desktops_change_tier`).
Test plan