desktops/common: use epiphany-browser on Ubuntu/riscv64#870
desktops/common: use epiphany-browser on Ubuntu/riscv64#870igorpecovnik merged 1 commit intomainfrom
Conversation
The noble/jammy/resolute riscv64 entries in the browser map pointed at 'firefox', which is wrong on several fronts: - Mozilla doesn't publish riscv64 binaries (tier-3 arch upstream), so there's nothing for apt.armbian.com to repackage. - Ubuntu's 'firefox' apt name is the snap-transitional .deb — it pulls snapd, which Armbian doesn't ship. - 'firefox-esr' is Debian-only and returns 'No such package' on packages.ubuntu.com/noble/riscv64 (and jammy / resolute). Fall back to GNOME Web (epiphany-browser): native GTK, no snap dependency, small footprint, built for riscv64 on every Ubuntu release we care about. Already the recommended Ubuntu-fallback in this file's own docstring for similar snap-shim cases.
WalkthroughA YAML configuration file for desktop package mappings is updated to change the browser package selection for Ubuntu releases Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tools/modules/desktops/yaml/common.yaml`:
- Around line 106-110: Update the wording around the riscv64 browser fallback:
clarify that the `firefox` package exists only as a transitional snap-shim (not
a native deb) rather than saying it isn’t in the archive, and keep the fallback
mapping `riscv64: epiphany-browser`; add a note comment referencing Launchpad
Bug `#2086779` about an unresolved epiphany crash on Noble/riscv64 and require a
manual test-install + launch/load on a riscv64 image (in addition to the
existing parser smoke test) before making `epiphany-browser` the default.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 28509a04-1940-456d-9cf9-da560f346527
📒 Files selected for processing (1)
tools/modules/desktops/yaml/common.yaml
The
noble/jammy/resoluteentries in thebrowser:map resolved tofirefoxon riscv64, which doesn't install:firefoxpackage is the snap-transitional shim — pulls snapd, which Armbian doesn't ship.firefox-esris a Debian-only name;packages.ubuntu.com/noble/riscv64/firefox-esrreturns 'No such package'.Fall back to
epiphany-browser(GNOME Web): native GTK, no snap, available for riscv64 on every Ubuntu release we support. Matches the file's own docstring recommendation for Ubuntu-snap-shim cases.Smoke-tested via
parse_desktop_yaml.py xfce <release> riscv64 --tier mid: all three releases now resolvebrowsertoepiphany-browser.