Add deref builtin filter
#1021
Add deref builtin filter
#1021
Conversation
|
I think something is missing here? Nothing is happening. ^^' cc @djc |
|
Huh, yeah, I too can only activate automerge, but can't manually merge the PR. I didn't even know that automerge was a thing. :D |
|
Argh, find the error: (green circle might be related) |
|
Dark magic. Good catch! :) |
| @@ -331,6 +331,12 @@ fn test_flat_deep() { | |||
| #[template(path = "let-base.html")] | |||
| struct LetBase {} | |||
|
|
|||
| #[test] | |||
| fn test_let_base() { | |||
There was a problem hiding this comment.
Can we just suppress the lints instead? Or is this adding useful test coverage?
There was a problem hiding this comment.
The lint is valid, but allowing it for this struct would have been better.
There was a problem hiding this comment.
Want to put up a PR that removes the tests in favor of suppressing the lints here?
There was a problem hiding this comment.
Fixed it in the last commit of #1029.
There was a problem hiding this comment.
Ah we commented at the same time haha. So like I said, last commit of #1029. Can send it as a standalone PR if you prefer.
There was a problem hiding this comment.
No, folding it into the other PR is fine.
Since we have
as_ref, sometimes it's better to remove references than to add more. :)