Skip to content

derive: no panics, less work, more compatibility #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2024
Merged

derive: no panics, less work, more compatibility #132

merged 3 commits into from
Aug 13, 2024

Conversation

Kijewski
Copy link
Member

Some minor stuff I found while implementing #127; extracted from there.

  • allow any amount of invisible delimiters: more compatibility with generated TokenStreams
  • don't panic if source+path are missing: print an error message instead
  • don't write empty string: because even printing nothing causes work

@GuillaumeGomez
Copy link
Collaborator

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 275e7e9 into askama-rs:master Aug 13, 2024
17 checks passed
@Kijewski Kijewski deleted the pr-derive-a-bit branch August 13, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kijewski @GuillaumeGomez