Second round of optimizations extracted from PR to implement enum variants
#266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| pub(crate) enum Source { | ||
| Path(String), | ||
| Path(Arc<str>), |
There was a problem hiding this comment.
Why an Arc and not an Rc btw? Do we need Source to be Send?
There was a problem hiding this comment.
The other variant Source::Source needs an Arc to be compatible with cached file sources. Source::Path does not, but I think making both variants the same is still the better call. The Clone and Drop implementations are half the size, which I daresay outperforms any drawbacks the use of atomic numbers bring.
There was a problem hiding this comment.
Right, forgot about the static. That answers my question. :)
GuillaumeGomez
approved these changes
Nov 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.