Dispose disposable HttpContext

[benaadams]

HttpContext is IDisposable so should be disposed at the end of the request.

Would suggest Func<IFeatureCollection, Task> application change to Func<IFeatureCollection, Task<IDisposable>> application in IServerFactory.Start

The Server Factory should then return the HttpContext from the closure: https://github.com/aspnet/Hosting/blob/dev/src/Microsoft.AspNet.Hosting/Internal/HostingEngine.cs#L88 to allow it to be disposed at the end of the request.

[muratg]

@Tratcher was there a particular reason why we weren't doing this?

[Tratcher]

I don't think we ever really thought though it. I don't know why it was ever marked as IDisposable in the first place, we haven't found a use for it before now. @benaadams's attempted use of it highlights some of the potential issues, such as non-deterministic lifetime.

I'd recommend removing IDisposable rather than trying to call it.

[halter73]

👍 for removing IDisposable from HttpContext if possible.

[muratg]

Sounds good, good riddance IDisposable!