Skip to content
This repository was archived by the owner on Nov 7, 2018. It is now read-only.
This repository was archived by the owner on Nov 7, 2018. It is now read-only.

IOptionsMonitor should be updated for 2.0 #201

Closed
@HaoK

Description

@HaoK

Related #199

Snapshot shouldn't responsible for registering IOptionsChangeTokenSource

I think we need to update IOptionsMonitor to use the new 2.0 functionality especially now that logging uses it.

Proposed changes for IOptionsMonitor

  • Use IOptionsFactory / support names / post configures
  • Use the IOptionsCache to get live updates / handle cache invalidations (should potentially revisit the config reload token hookup to see if there's any improvements there)

@ajcvickers @divega thoughts? With logging using options monitor, its gone from not very important to super important scenario, and it got 0 love in 2.0 so far...

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions