Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

Replaced the default to be the inputpath rather than the CWD '.'#80

Open
radding wants to merge 3 commits intoasticode:masterfrom
shuttl-io:master
Open

Replaced the default to be the inputpath rather than the CWD '.'#80
radding wants to merge 3 commits intoasticode:masterfrom
shuttl-io:master

Conversation

@radding
Copy link
Copy Markdown

@radding radding commented Oct 31, 2020

I need this because I am using go modules outside of the GOPATH and my structure is a little different like so:

/root
  \ cmd
    \ cmd1
      \ main.go
  \ internal
    \gui
      \ ...
bundler.json

Being able to tell the bundler to build ./cmd/cmd1 is useful. THe current implementation doesn't take into account input_path

@asticode
Copy link
Copy Markdown
Owner

This makes sense. Could you add a comment above if c.InputPath != "" { explaining why you need it ? That will be useful in the future

@radding
Copy link
Copy Markdown
Author

radding commented Nov 1, 2020

@asticode Done!

@asticode
Copy link
Copy Markdown
Owner

asticode commented Nov 2, 2020

I had forgotten to push last changes to master and your go.sum now conflicts with master's. Could you fetch last changes and not update go.sum ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants