Adds onError with just the ability to change the fall back value, cus…#75
Open
dwjohnston wants to merge 1 commit into
Open
Adds onError with just the ability to change the fall back value, cus…#75dwjohnston wants to merge 1 commit into
dwjohnston wants to merge 1 commit into
Conversation
This was referenced Nov 18, 2024
Open
dwjohnston
commented
Nov 18, 2024
| // I really want to be able to write a test like this! | ||
| // But it's not working? JSDOM has implemented the storageEvent thought: | ||
| // https://github.com/jsdom/jsdom/pull/2076 | ||
| test.skip("sanity test", async () => { |
| @@ -25,7 +27,13 @@ beforeEach(() => { | |||
| // (`Component`). To locate the bad setState() call inside `Component`, follow the stack trace | |||
| // as described in https://reactjs.org/link/setstate-in-render" | |||
| vi.spyOn(console, 'error').mockImplementation((format: string, ...args: any[]) => { | |||
Author
There was a problem hiding this comment.
I do like this pattern.
What I've done in the past is maintained a list of allowed errors, and a second list of errors that should be printed to the console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
onErroroption, that allows the user to: