-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ty] Fix redundant-cast
false positives when casting to Unknown
#18111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
carljm
approved these changes
May 15, 2025
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type::contains_todo()
into a genericType::any_over_type
method, similar to ourany_over_expr
function for recursing into AST nodes:ruff/crates/ruff_python_ast/src/helpers.rs
Lines 129 to 131 in 466021d
redundant-cast
diagnostics if a user is casting toUnknown
, since this breaks the gradual guarantee#18112 is stacked on top of this PR, because otherwise that PR causes some small breakages in our
redundant-cast
mdtests.Closes #18058
Test Plan
mdtests added