[refurb] Mark FURB180 fix unsafe when class has bases
#18149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntBre could you take a look at this PR when you're back? |
ntBre
added
bug
ntBre
approved these changes
May 29, 2025
| @@ -69,6 +74,7 @@ pub(crate) fn metaclass_abcmeta(checker: &Checker, class_def: &StmtClassDef) { | |||
| return; | |||
| } | |||
|
|
|||
| let has_bases = !class_def.bases().is_empty(); | |||
There was a problem hiding this comment.
nit: I think we could use something like this here:
Suggested change
| let has_bases = !class_def.bases().is_empty(); | |
| let applicability = if class_def.bases().is_empty() { Applicability::Safe } else { Applicability::Unsafe }; |
And then instead of the make_fix method, we can just use Fix::applicable_edits where we previously used Fix::safe_edits. You could then move your comments from make_fix here too, or possibly delete them too since I think you covered it nicely in the Fix safety section.
There was a problem hiding this comment.
Thank you very much. Nit happily applied.
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| FURB180 | 24 | 0 | 0 | 0 | 24 |
ntBre
approved these changes
Jun 3, 2025
ntBre
changed the title
refurb] Mark FURB180 fix unsafe when class has bases
dcreager
added a commit
that referenced
this pull request
Jun 3, 2025
…aration * origin/main: [ty] Infer `list[T]` when unpacking non-tuple type (#18438) [ty] Meta-type of type variables should be type[..] (#18439) [`pyupgrade`] Make fix unsafe if it deletes comments (`UP050`) (#18390) [`pyupgrade`] Make fix unsafe if it deletes comments (`UP004`) (#18393) [ty] Support using legacy typing aliases for generic classes in type annotations (#18404) Use ty's completions in playground (#18425) Update editor setup docs about Neovim and Vim (#18324) Update NPM Development dependencies (#18423) Infer `list[T]` for starred target in unpacking (#18401) [`refurb`] Mark `FURB180` fix unsafe when class has bases (#18149) [`fastapi`] Avoid false positive for class dependencies (`FAST003`) (#18271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mark
FURB180's fix as unsafe if the class already has base classes. This is because the base classes might validate the other base classes (liketyping.Protocoldoes) or otherwise alter runtime behavior if more base classes are added.Test Plan
The existing snapshot test covers this case already.
References
Partially addresses #13307 (left out way to permit certain exceptions)