Update T201 suggestion to not use root logger to satisfy LOG015 #22059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the proposed fix violates https://docs.astral.sh/ruff/rules/root-logger-call/. Thus, let's change to proposal to make it happy as well.
cbachhuber
commented
Dec 18, 2025
Comment on lines
39
to
+40
| /// logging.basicConfig(level=logging.INFO) | ||
| /// logger = logging.getLogger(__name__) |
Contributor
Author
There was a problem hiding this comment.
This will prepend the file and log level to any log message. If that's not ok, we can
Suggested change
| /// logging.basicConfig(level=logging.INFO) | |
| /// logger = logging.getLogger(__name__) | |
| /// logging.basicConfig(level=logging.INFO, format="%(message)s") | |
| /// logger = logging.getLogger(__name__) |
|
amyreese
approved these changes
Dec 19, 2025
Member
amyreese
left a comment
amyreese
left a comment
There was a problem hiding this comment.
I know why it's there, but IMO the suggested fix shouldn't include logging.basicConfig() at the global module level due to the race condition around which call "wins" based on which module is imported first.
Otherwise, I whole-heartedly agree with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the proposed fix for https://docs.astral.sh/ruff/rules/print/ violates https://docs.astral.sh/ruff/rules/root-logger-call/. Thus, let's change the proposal to make LOG015 happy as well.
Test Plan
Test manually in a project that has both T201 and LOG015 enabled and run them over the previous and proposed code. Is there continuous testing of the code snippets from the docs?