[ruff] Improve fix title for RUF102 invalid rule code
#22100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyreese
added
fixes
amyreese
requested review from
MichaReiser and
ntBre
and removed request for
ntBre
|
MichaReiser
approved these changes
Dec 22, 2025
| | ----- | ||
| | | ||
| help: Remove the rule code | ||
| help: Remove the suppression comment |
Member
There was a problem hiding this comment.
Does RUF100 need a similar treatment?
Member
Author
There was a problem hiding this comment.
That was already addressed for RUF100 in a previous PR.
amyreese
force-pushed
the
amy/group-diagnostics
branch
from
0f38751 to
e067aa0
Compare
amyreese
force-pushed
the
amy/invalid-rule-code-message
branch
from
effaf2a to
ecb9620
Compare
amyreese
force-pushed
the
amy/invalid-rule-code-message
branch
from
ecb9620 to
157e5a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the fix title for RUF102 to either specify which rule code to remove, or clarify
that the entire suppression comment should be removed.
Test Plan
Updated test snapshots.