[flake8_print] better suggestion for basicConfig in T201 docs
#22101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`logging.basicConfig` should not be called at a global module scope, as that produces a race condition to configure logging based on which module gets imported first. Logging should instead be initialized in an entrypoint to the program, either in a `main()` or in the typical `if __name__ == "__main__"` block.
|
MichaReiser
approved these changes
Dec 22, 2025
MichaReiser
reviewed
Dec 22, 2025
MichaReiser
approved these changes
Dec 22, 2025
ntBre
approved these changes
Dec 22, 2025
amyreese
force-pushed
the
amy/t201-basicconfig
branch
from
f285a9a to
cb9c09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
logging.basicConfigshould not be called at a global module scope,as that produces a race condition to configure logging based on which
module gets imported first. Logging should instead be initialized
in an entrypoint to the program, either in a
main()or in thetypical
if __name__ == "__main__"block.Test Plan
tbd