Skip to content

flake8-simplify: avoid unnecessary builtins import for SIM105 #22358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaReiser merged 1 commit into from
Jan 5, 2026
+15 −19
Merged

flake8-simplify: avoid unnecessary builtins import for SIM105 #22358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions crates/ruff_linter/src/rules/flake8_simplify/rules/suppressible_exception.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,11 @@ pub(crate) fn suppressible_exception(
let mut rest: Vec<Edit> = Vec::new();
let content: String;
if exception == "BaseException" && handler_names.is_empty() {
let (import_exception, binding_exception) =
checker.importer().get_or_import_symbol(
&ImportRequest::import("builtins", &exception),
stmt.start(),
checker.semantic(),
)?;
let (import_exception, binding_exception) = checker
.importer()
.get_or_import_builtin_symbol(&exception, stmt.start(), checker.semantic())?;
content = format!("with {binding}({binding_exception})");
rest.push(import_exception);
rest.extend(import_exception);
} else {
content = format!("with {binding}({exception})");
}
Expand Down
23 changes: 11 additions & 12 deletions ...e8_simplify/snapshots/ruff_linter__rules__flake8_simplify__tests__SIM105_SIM105_0.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,22 +104,21 @@ SIM105 [*] Use `contextlib.suppress(BaseException)` instead of `try`-`except`-`p
|
help: Replace `try`-`except`-`pass` with `with contextlib.suppress(BaseException): ...`
1 + import contextlib
2 + import builtins
3 | def foo():
4 | pass
5 |
2 | def foo():
3 | pass
4 |
--------------------------------------------------------------------------------
24 | pass
25 |
26 | # SIM105
23 | pass
24 |
25 | # SIM105
- try:
27 + with contextlib.suppress(builtins.BaseException):
28 | foo()
26 + with contextlib.suppress(BaseException):
27 | foo()
- except:
- pass
29 |
30 | # SIM105
31 | try:
28 |
29 | # SIM105
30 | try:
note: This is an unsafe fix and may change runtime behavior

SIM105 [*] Use `contextlib.suppress(a.Error, b.Error)` instead of `try`-`except`-`pass`
Expand Down