Noisily allow redundant entries in `tool.uv.build-backend.module-name` #16928

EliteTK · 2025-12-02T12:08:50Z

Summary

Fix #16906 by pruning modules or submodules which are already included (either directly, or through a parent).

Generates warnings when this happens.

Example:

$ uv build
Building source distribution (uv build backend)...
warning: Ignoring redundant module name(s): test_lib.bar test_lib test_lib.bar.baz test_lib.baz
Building wheel from source distribution (uv build backend)...
Successfully built dist/test-0.1.0.tar.gz
Successfully built dist/test-0.1.0-py3-none-any.whl

Test Plan

Added some unit tests for the pruning function and one for the whole build backend. Added an integration test for the warnings. Ran the full test suite. Manually tested.

The unit test for the function doesn't cater for the fact that it doesn't guarantee an order at the moment. I think this is fine.

Outstanding/Questions

Figure out how to only present warnings when appropriate (when building something the user controls).

crates/uv-build-backend/src/lib.rs

E.g. "foo" already includes "foo", and "foo.bar" but not "foobar".

Co-authored-by: konsti <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.13` -> `0.9.17` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.9.17`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0917) [Compare Source](astral-sh/uv@0.9.16...0.9.17) Released on 2025-12-09. ##### Enhancements - Add `torch-tensorrt` and `torchao` to the PyTorch list ([#17053](astral-sh/uv#17053)) - Add hint for misplaced `--verbose` in `uv tool run` ([#17020](astral-sh/uv#17020)) - Add support for relative durations in `exclude-newer` (a.k.a., dependency cooldowns) ([#16814](astral-sh/uv#16814)) - Add support for relocatable nushell activation script ([#17036](astral-sh/uv#17036)) ##### Bug fixes - Respect dropped (but explicit) indexes in dependency groups ([#17012](astral-sh/uv#17012)) ##### Documentation - Improve `source-exclude` reference docs ([#16832](astral-sh/uv#16832)) - Recommend `UV_NO_DEV` in Docker installs ([#17030](astral-sh/uv#17030)) - Update `UV_VERSION` in docs for GitLab CI/CD ([#17040](astral-sh/uv#17040)) ### [`v0.9.16`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0916) [Compare Source](astral-sh/uv@0.9.15...0.9.16) Released on 2025-12-06. ##### Python - Add CPython 3.14.2 - Add CPython 3.13.11 ##### Enhancements - Add a 5m default timeout to acquiring file locks to fail faster on deadlock ([#16342](astral-sh/uv#16342)) - Add a stub `debug` subcommand to `uv pip` announcing its intentional absence ([#16966](astral-sh/uv#16966)) - Add bounds in `uv add --script` ([#16954](astral-sh/uv#16954)) - Add brew specific message for `uv self update` ([#16838](astral-sh/uv#16838)) - Error when built wheel is for the wrong platform ([#16074](astral-sh/uv#16074)) - Filter wheels from PEP 751 files based on `--no-binary` et al in `uv pip compile` ([#16956](astral-sh/uv#16956)) - Support `--target` and `--prefix` in `uv pip list`, `uv pip freeze`, and `uv pip show` ([#16955](astral-sh/uv#16955)) - Tweak language for build backend validation errors ([#16720](astral-sh/uv#16720)) - Use explicit credentials cache instead of global static ([#16768](astral-sh/uv#16768)) - Enable SIMD in HTML parsing ([#17010](astral-sh/uv#17010)) ##### Preview features - Fix missing preview warning in `uv workspace metadata` ([#16988](astral-sh/uv#16988)) - Add a `uv auth helper --protocol bazel` command ([#16886](astral-sh/uv#16886)) ##### Bug fixes - Fix Pyston wheel compatibility tags ([#16972](astral-sh/uv#16972)) - Allow redundant entries in `tool.uv.build-backend.module-name` but emit warnings ([#16928](astral-sh/uv#16928)) - Fix infinite loop in non-attribute re-treats during HTML parsing ([#17010](astral-sh/uv#17010)) ##### Documentation - Clarify `--project` flag help text to indicate project discovery ([#16965](astral-sh/uv#16965)) - Regenerate the crates.io READMEs on release ([#16992](astral-sh/uv#16992)) - Update Docker integration guide to prefer `COPY` over `ADD` for simple cases ([#16883](astral-sh/uv#16883)) - Update PyTorch documentation to include information about supporting CUDA 13.0.x ([#16957](astral-sh/uv#16957)) - Update the versioning policy ([#16710](astral-sh/uv#16710)) - Upgrade PyTorch documentation to latest versions ([#16970](astral-sh/uv#16970)) ### [`v0.9.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0915) [Compare Source](astral-sh/uv@0.9.14...0.9.15) Released on 2025-12-02. ##### Python - Add CPython 3.14.1 - Add CPython 3.13.10 ##### Enhancements - Add ROCm 6.4 to `--torch-backend=auto` ([#16919](astral-sh/uv#16919)) - Add a Windows manifest to uv binaries ([#16894](astral-sh/uv#16894)) - Add LFS toggle to Git sources ([#16143](astral-sh/uv#16143)) - Cache source reads during resolution ([#16888](astral-sh/uv#16888)) - Allow reading requirements from scripts without an extension ([#16923](astral-sh/uv#16923)) - Allow reading requirements from scripts with HTTP(S) paths ([#16891](astral-sh/uv#16891)) ##### Configuration - Add `UV_HIDE_BUILD_OUTPUT` to omit build logs ([#16885](astral-sh/uv#16885)) ##### Bug fixes - Fix `uv-trampoline-builder` builds from crates.io by moving bundled executables ([#16922](astral-sh/uv#16922)) - Respect `NO_COLOR` and always show the command as a header when paging `uv help` output ([#16908](astral-sh/uv#16908)) - Use `0o666` permissions for flock files instead of `0o777` ([#16845](astral-sh/uv#16845)) - Revert "Bump `astral-tl` to v0.7.10 ([#16887](astral-sh/uv#16887))" to narrow down a regression causing hangs in metadata retrieval ([#16938](astral-sh/uv#16938)) ##### Documentation - Link to the uv version in crates.io member READMEs ([#16939](astral-sh/uv#16939)) ### [`v0.9.14`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0914) [Compare Source](astral-sh/uv@0.9.13...0.9.14) Released on 2025-12-01. ##### Performance - Bump `astral-tl` to v0.7.10 to enable SIMD for HTML parsing ([#16887](astral-sh/uv#16887)) ##### Bug fixes - Allow earlier post releases with exclusive ordering ([#16881](astral-sh/uv#16881)) - Prefer updating existing `.zshenv` over creating a new one in `tool update-shell` ([#16866](astral-sh/uv#16866)) - Respect `-e` flags in `uv add` ([#16882](astral-sh/uv#16882)) ##### Enhancements - Attach subcommand to User-Agent string ([#16837](astral-sh/uv#16837)) - Prefer `UV_WORKING_DIR` over `UV_WORKING_DIRECTORY` for consistency ([#16884](astral-sh/uv#16884)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

EliteTK requested a review from konstin December 2, 2025 12:08

EliteTK added the bug Something isn't working label Dec 2, 2025

konstin reviewed Dec 2, 2025

View reviewed changes

crates/uv-build-backend/src/lib.rs Outdated Show resolved Hide resolved

crates/uv-build-backend/src/lib.rs Outdated Show resolved Hide resolved

EliteTK force-pushed the dedupe-mod-names branch 2 times, most recently from 38ad8a3 to bfb1739 Compare December 2, 2025 14:21

EliteTK requested a review from konstin December 2, 2025 14:25

zanieb reviewed Dec 2, 2025

View reviewed changes

crates/uv-build-backend/src/lib.rs Outdated Show resolved Hide resolved

zanieb reviewed Dec 2, 2025

View reviewed changes

crates/uv-build-backend/src/lib.rs Outdated Show resolved Hide resolved

EliteTK marked this pull request as ready for review December 2, 2025 17:17

konstin reviewed Dec 3, 2025

View reviewed changes

crates/uv-build-backend/src/lib.rs Outdated Show resolved Hide resolved

konstin approved these changes Dec 3, 2025

View reviewed changes

EliteTK enabled auto-merge (squash) December 3, 2025 09:29

EliteTK disabled auto-merge December 3, 2025 09:36

EliteTK and others added 8 commits December 3, 2025 09:46

Noisily ignore module names which are already included

2715c5a

E.g. "foo" already includes "foo", and "foo.bar" but not "foobar".

Make prune_redundant_modules a link

081e8df

Dynamically pluralize names

96b2e99

Make warnings conditional

109f836

Don't use namespaces for the test

0e2e2e8

Expand test to check for the no-warning case

e094713

Improve warning message

6042340

Co-authored-by: konsti <[email protected]>

Update snapshot to match new warning message

af9a58c

EliteTK force-pushed the dedupe-mod-names branch from add443d to af9a58c Compare December 3, 2025 09:52

EliteTK enabled auto-merge (squash) December 3, 2025 09:53

EliteTK merged commit f01366b into astral-sh:main Dec 3, 2025
101 checks passed

EliteTK deleted the dedupe-mod-names branch December 3, 2025 11:10

This was referenced Dec 3, 2025

Refactor uv_build warning handling #16961

Open

Consider making the uv_build warning heuristic more precise #16962

Open

BrewTestBot mentioned this pull request Dec 6, 2025

uv 0.9.16 Homebrew/homebrew-core#257541

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Noisily allow redundant entries in `tool.uv.build-backend.module-name` #16928

Noisily allow redundant entries in `tool.uv.build-backend.module-name` #16928

Uh oh!

EliteTK commented Dec 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Noisily allow redundant entries in tool.uv.build-backend.module-name #16928

Noisily allow redundant entries in tool.uv.build-backend.module-name #16928

Uh oh!

Conversation

EliteTK commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Outstanding/Questions

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Noisily allow redundant entries in `tool.uv.build-backend.module-name` #16928

Noisily allow redundant entries in `tool.uv.build-backend.module-name` #16928

EliteTK commented Dec 2, 2025 •

edited

Loading