Skip to content

Conversation

@jkipper
Copy link
Contributor

@jkipper jkipper commented Dec 5, 2025

Summary

Pyproject.toml index url may contain a username while lockfile doesn't. Treat it as the same index to prevent unintended package updates

Fixes #16436

@jkipper jkipper force-pushed the fix/authenticated-update branch 2 times, most recently from d99f35f to 106a6a4 Compare December 5, 2025 07:54
@zanieb
Copy link
Member

zanieb commented Dec 6, 2025

Do you have an integration test, e.g., for uv lock that demonstrates that this fixes #16436 ?

@jkipper
Copy link
Contributor Author

jkipper commented Dec 8, 2025

Not directly, turns out I did not add the part that actually caused the issue in that. Still not sure why I found that correlation but it's not happening that way anymore and the username part is what I was actually seeing. (I originally reported that issue)

@zanieb
Copy link
Member

zanieb commented Dec 8, 2025

Sorry I don't quite understand what you mean.

@jkipper
Copy link
Contributor Author

jkipper commented Dec 8, 2025

I reported that issue based on my observation that it was related to which sort of packaging was used, but the upgrade was actually caused by adding a username to an index.

So this fixes the linked issue, but the actual cause wasn't included when I reported it.

@zanieb
Copy link
Member

zanieb commented Dec 8, 2025

I think we need an integration test case that demonstrates the change in behavior this pull request causes, i.e., at the uv lock level

@jkipper jkipper force-pushed the fix/authenticated-update branch 3 times, most recently from f31c265 to 30b8a00 Compare December 9, 2025 14:10
@jkipper
Copy link
Contributor Author

jkipper commented Dec 9, 2025

Got it. Added one now.

@jkipper jkipper force-pushed the fix/authenticated-update branch from 30b8a00 to 7a937aa Compare December 9, 2025 14:12
@jkipper jkipper force-pushed the fix/authenticated-update branch from 7a937aa to 6f5c83b Compare December 12, 2025 17:57
@konstin konstin added the bug Something isn't working label Dec 16, 2025
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@konstin konstin enabled auto-merge (squash) December 16, 2025 10:37
@konstin konstin merged commit af348c2 into astral-sh:main Dec 16, 2025
101 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 18, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.9.17` -> `0.9.18` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.9.18`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0918)

[Compare Source](astral-sh/uv@0.9.17...0.9.18)

Released on 2025-12-16.

##### Enhancements

- Add value hints to command line arguments to improve shell completion accuracy ([#&#8203;17080](astral-sh/uv#17080))
- Improve error handling in `uv publish` ([#&#8203;17096](astral-sh/uv#17096))
- Improve rendering of multiline error messages ([#&#8203;17132](astral-sh/uv#17132))
- Support redirects in `uv publish` ([#&#8203;17130](astral-sh/uv#17130))
- Include Docker images with the alpine version, e.g., `python3.x-alpine3.23` ([#&#8203;17100](astral-sh/uv#17100))

##### Configuration

- Accept `--torch-backend` in `[tool.uv]` ([#&#8203;17116](astral-sh/uv#17116))

##### Performance

- Speed up `uv cache size` ([#&#8203;17015](astral-sh/uv#17015))
- Initialize S3 signer once ([#&#8203;17092](astral-sh/uv#17092))

##### Bug fixes

- Avoid panics due to reads on failed requests ([#&#8203;17098](astral-sh/uv#17098))
- Enforce latest-version in `@latest` requests ([#&#8203;17114](astral-sh/uv#17114))
- Explicitly set `EntryType` for file entries in tar ([#&#8203;17043](astral-sh/uv#17043))
- Ignore `pyproject.toml` index username in lockfile comparison ([#&#8203;16995](astral-sh/uv#16995))
- Relax error when using `uv add` with `UV_GIT_LFS` set ([#&#8203;17127](astral-sh/uv#17127))
- Support file locks on ExFAT on macOS ([#&#8203;17115](astral-sh/uv#17115))
- Change schema for `exclude-newer` into optional string ([#&#8203;17121](astral-sh/uv#17121))

##### Documentation

- Drop arm musl caveat from Docker documentation ([#&#8203;17111](astral-sh/uv#17111))
- Fix version reference in resolver example ([#&#8203;17085](astral-sh/uv#17085))
- Better documentation for `exclude-newer*` ([#&#8203;17079](astral-sh/uv#17079))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41Ny4xIiwidXBkYXRlZEluVmVyIjoiNDIuNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lock upgrades some locked dependencies with no --upgrade flag

3 participants