Skip to content

Add value hints to command line arguments to improve shell completion accuracy #17080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EliteTK merged 8 commits into from
Dec 15, 2025
+401 −156
Merged

Add value hints to command line arguments to improve shell completion accuracy #17080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73b1603
Add value_hint = ValueHint::FilePath where appropriate
EliteTK Dec 10, 2025
ab42a2b
Add value_hint = ValueHint::DirPath where appropriate
EliteTK Dec 10, 2025
92df32e
Add value_hint = ValueHint::Url where appropriate
EliteTK Dec 10, 2025
6aca913
Add value_hint = ValueHint::CommandName where appropriate
EliteTK Dec 10, 2025
c944883
Add value_hint = ValueHint::Other where appropriate
EliteTK Dec 10, 2025
3e4c3a8
ValueHint::Other for python interpreter
EliteTK Dec 15, 2025
3896664
Consistently use ValueHint::DirPath for all with_editable
EliteTK Dec 15, 2025
e7c6c1a
Add missing ValueHints for CommaSeparatedRequirements
EliteTK Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/uv-cache/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::path::{Path, PathBuf};
use uv_static::EnvVars;

use crate::Cache;
use clap::Parser;
use clap::{Parser, ValueHint};
use tracing::{debug, warn};

#[derive(Parser, Debug, Clone)]
Expand All @@ -27,7 +27,7 @@ pub struct CacheArgs {
/// `%LOCALAPPDATA%\uv\cache` on Windows.
///
/// To view the location of the cache directory, run `uv cache dir`.
#[arg(global = true, long, env = EnvVars::UV_CACHE_DIR)]
#[arg(global = true, long, env = EnvVars::UV_CACHE_DIR, value_hint = ValueHint::DirPath)]
pub cache_dir: Option<PathBuf>,
}

Expand Down
Loading
Loading