Skip to content

fix(deploy: exit non-zero if uncommitted changes are present - #2004

Open
sakethsomaraju wants to merge 1 commit into
mainfrom
fix/1721
Open

fix(deploy: exit non-zero if uncommitted changes are present#2004
sakethsomaraju wants to merge 1 commit into
mainfrom
fix/1721

Conversation

@sakethsomaraju

@sakethsomaraju sakethsomaraju commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Description

Describe the purpose of this pull request.

Customers using GitLab or other CI/CD platforms rely on command exit codes to programmatically determine whether an astro deploy invocation succeeded or failed.

🎟 Issue(s)

Related #1721

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.
Run astro deploy with uncommitted git changes --> command fails with error and exits non-zero.

Run astro deploy -f with uncommitted changes --> deploy proceeds successfully.

Run astro deploy with a clean git state --> deploy succeeds as before.

📸 Screenshots

image

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@sakethsomaraju sakethsomaraju self-assigned this Feb 2, 2026
@sakethsomaraju
sakethsomaraju marked this pull request as ready for review February 2, 2026 06:21
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions Bot added the stale label Apr 14, 2026
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 29357736272

Coverage increased (+0.001%) to 43.89%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (0 of 1 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
cmd/cloud/deploy.go 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 59016
Covered Lines: 25902
Line Coverage: 43.89%
Coverage Strength: 8.55 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant