Skip to content

refactor: remove unused dependencies #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Jun 9, 2025

Description
CLI has some unsed dependencies, this pr aims to clear those and have a lean package.json file, thus improving time it takes to install dependencies in development and ci/cd pipelines.

According to depcheck:

Unused dependencies
* @oclif/plugin-autocomplete
* node-fetch
* reflect-metadata
* serve-handler
* strip-ansi
Unused devDependencies
* @asyncapi/minimaltemplate
* @asyncapi/newtemplate
* @babel/core
* @types/chai
* @types/node-fetch
* @types/serve-handler
* @types/wrap-ansi
* acorn
* chai
* eslint-config-oclif
* eslint-config-oclif-typescript
* globby
* tslib
Missing dependencies
* @jest/types: ./jest.config.ts
* @stoplight/spectral-core: ./src/core/parser.ts
* @stoplight/spectral-formatters: ./src/core/parser.ts
* core: ./src/core/models/SpecificationFile.ts
* @asyncapi/specs: ./src/commands/convert.ts
* jsonfile: ./src/commands/new/template.ts
* read-package-up: ./.github/workflows/changeset-utils/index.js


Related issue(s)

Fixes #1707

Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: 544c42a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Souvikns Souvikns marked this pull request as ready for review June 9, 2025 16:09
@Souvikns
Copy link
Member Author

Souvikns commented Jun 9, 2025

@Shurtu-gal @AayushSaini101 feel free to review, let me know if autocomplete is being used somewhere I am not sure about this one.

@Shurtu-gal
Copy link
Collaborator

Autocomplete us being used. @AayushSaini101 added autocomplete feature recently.

@Souvikns
Copy link
Member Author

Souvikns commented Jun 9, 2025

alright, will be adding it back.

Copy link

sonarqubecloud bot commented Jun 9, 2025

Copy link
Collaborator

@AayushSaini101 AayushSaini101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from To Triage to Backlog in CLI - Kanban Jun 11, 2025
@Shurtu-gal
Copy link
Collaborator

Is globby also not being used? It was used in auto update of studio right?

Or are we using chai directly.

@Souvikns
Copy link
Member Author

Souvikns commented Jun 12, 2025

Well, the tests are all running, so looks like it is not being used. We are using chai directly

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 296af0a into asyncapi:master Jun 12, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in CLI - Kanban Jun 12, 2025
IITI-tushar pushed a commit to IITI-tushar/asyncAPI-cli that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Too many unused dependencies
4 participants