fix(style): scroll to top button design #3708

Recxsmacx · 2025-02-18T15:00:18Z

Update the scroll to top button to use Next.js <Image> component and improve design.

Replace <img> tag with Next.js <Image> component in components/buttons/ScrollButton.tsx
Adjust the styling of the button to make it more elegant and clean
Fix the spacing and distance from the sides
Make the parent div flex to fix the layout spacing issue

Fixes #3614 Update the scroll to top button to use Next.js `<Image>` component and improve design. * Replace `<img>` tag with Next.js `<Image>` component in `components/buttons/ScrollButton.tsx` * Adjust the styling of the button to make it more elegant and clean * Fix the spacing and distance from the sides * Make the parent div flex to fix the layout spacing issue

coderabbitai · 2025-02-18T15:00:34Z

Walkthrough

This pull request updates the ScrollButton component by replacing the standard <img> tag with Next.js’ Image component for image rendering. The CSS for the button container is modified—changing the vertical positioning from bottom-14 to bottom-4—and additional padding (p-2) is added to the button. The functional behavior, where the button appears based on scroll position and scrolls the page to the top when clicked, remains unchanged.

Changes

Files	Summary of Changes
components/buttons/ScrollButton.tsx	Replaced `<img>` tag with `Image` component, updated container positioning (from `bottom-14` to `bottom-4`), and added `p-2` padding.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant SB as ScrollButton
    participant NI as Next/Image
    U->>SB: Trigger scroll event (visibility check)
    SB->>NI: Render scroll icon using optimized image
    U->>SB: Click button to scroll top
    SB->>U: Scroll page to top

Possibly related PRs

feat: make scroll to top button attractive with hover effects #3605: Modifies the ScrollButton component styling with hover effects and class updates.
fix: improving scroll to top button elegent and clean design #3637: Replaces the <img> tag with the Image component and adjusts CSS properties in the ScrollButton component.

Suggested labels

ready-to-merge

Suggested reviewers

derberg
magicmatatjahu
devilkiller-ag
akshatnema
sambhavgupta0705
asyncapi-bot-eve
Mayaleeeee
anshgoyalevil

Poem

I'm a bunny in the code burrow, full of cheer,
Hop through the changes with a skip and a tear.
The scroll button now gleams with optimized light,
Padded just right, it makes my day bright.
With whiskers twitching, I code all night! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Recxsmacx · 2025-02-18T15:00:54Z

previous output

the final output

netlify · 2025-02-18T15:01:07Z

❌ Deploy Preview for asyncapi-website failed.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`a5004f4`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/67b4a085bc746800082358c9

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1c7f7c and a5004f4.

📒 Files selected for processing (1)

components/buttons/ScrollButton.tsx (2 hunks)

🧰 Additional context used

🪛 ESLint

components/buttons/ScrollButton.tsx

[error] 1-2: Run autofix to sort these imports!

(simple-import-sort/imports)

🪛 GitHub Actions: PR testing - if Node project

components/buttons/ScrollButton.tsx

[error] 1-1: Run autofix to sort these imports! simple-import-sort/imports

⏰ Context from checks skipped due to timeout of 180000ms (1)

GitHub Check: Lighthouse CI

🔇 Additional comments (2)

components/buttons/ScrollButton.tsx (2)

36-36: Great use of Next.js Image component!

The implementation follows Next.js best practices by:

Using the optimized Image component

Setting explicit width and height

Providing descriptive alt text

30-30: Excellent UI/UX improvements!

The styling changes enhance the button's design through:

Proper flexbox layout for centering

Smooth transitions and hover effects

Consistent spacing with p-2 padding

Improved positioning with bottom-4

Also applies to: 33-33

components/buttons/ScrollButton.tsx

sambhavgupta0705 · 2025-02-18T17:16:22Z

@Recxsmacx the build is failing

TRohit20

@Recxsmacx The website build seems to be failing so something needs to be addressed :)

sambhavgupta0705 · 2025-02-20T17:25:42Z

closing this as we can take this up with website redesigning

Recxsmacx requested review from derberg, akshatnema, anshgoyalevil, Mayaleeeee and asyncapi-bot-eve as code owners February 18, 2025 15:00

asyncapi-bot requested review from devilkiller-ag and sambhavgupta0705 February 18, 2025 15:00

Recxsmacx changed the title ~~fix scroll to top button design~~ fix(style): scroll to top button design Feb 18, 2025

coderabbitai bot reviewed Feb 18, 2025

View reviewed changes

components/buttons/ScrollButton.tsx Show resolved Hide resolved

Recxsmacx mentioned this pull request Feb 20, 2025

[FEATURE] Improving scroll to top button elegent and clean design #3614

Closed

2 tasks

Recxsmacx closed this Feb 20, 2025

Recxsmacx reopened this Feb 20, 2025

TRohit20 requested changes Feb 20, 2025

View reviewed changes

sambhavgupta0705 closed this Feb 20, 2025

coderabbitai bot mentioned this pull request Mar 4, 2025

fix: centered cards on case studies page maintaing responsiveness. #3791

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(style): scroll to top button design #3708

fix(style): scroll to top button design #3708

Uh oh!

Recxsmacx commented Feb 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Recxsmacx commented Feb 18, 2025 •

edited

Loading

Uh oh!

netlify bot commented Feb 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

sambhavgupta0705 commented Feb 18, 2025

Uh oh!

TRohit20 left a comment

Uh oh!

sambhavgupta0705 commented Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

fix(style): scroll to top button design #3708

fix(style): scroll to top button design #3708

Uh oh!

Conversation

Recxsmacx commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Recxsmacx commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for asyncapi-website failed.

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sambhavgupta0705 commented Feb 18, 2025

Uh oh!

TRohit20 left a comment

Choose a reason for hiding this comment

Uh oh!

sambhavgupta0705 commented Feb 20, 2025

Uh oh!

Uh oh!

Recxsmacx commented Feb 18, 2025 •

edited

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Recxsmacx commented Feb 18, 2025 •

edited

Loading

netlify bot commented Feb 18, 2025 •

edited

Loading