feat: Add utility for checking outdated password hashes during login flow#471
Merged
atinux merged 3 commits intoatinux:mainfrom Dec 9, 2025
Merged
feat: Add utility for checking outdated password hashes during login flow#471atinux merged 3 commits intoatinux:mainfrom
atinux merged 3 commits intoatinux:mainfrom
Conversation
gapple
changed the title
gapple
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If hash settings are changed, such as increasing the scrypt cost parameter, stored hash values are not updated until the user changes their password and a new hash is calculated with the new configuration and plaintext password.
Checking the parameters of the hashed password against the current configuration on successful login allows proactively replacing the stored hash of the user's existing plaintext password.
This would also assist in migrating hashes to a different algorithm, if
verifyPassword()was made algorithm-aware. Existing hashes would be checked against the algorithm that created them, buthashPassword()andpasswordNeedsReHash()would only need to use the current configuration values.