Skip to content

fix(Confluence): method attach_file() to not read() file content #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dunterov
Copy link
Contributor

Resolves #991

Underlying HTTP library supports streaming uploads using file-like objects. So now we just pass infile to attach_content()

Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.93%. Comparing base (fdaf1ff) to head (0bbaeaa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/confluence.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1535   +/-   ##
=======================================
  Coverage   33.93%   33.93%           
=======================================
  Files          47       47           
  Lines        9091     9090    -1     
  Branches     1232     1232           
=======================================
  Hits         3085     3085           
+ Misses       5884     5883    -1     
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gonchik gonchik merged commit 8ba93f1 into atlassian-api:master May 11, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confluence] attach_file should not have to read the whole file into RAM. Right?
2 participants