This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add HTML Entities Autocomplete #19
Open
+102
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. It looks like you put a lot of work into this. Thanks! ❤️ We just need someone to review it. It might take a little while as we have a high volume of PRs. |
|
Now that atom/language-html#98 has been merged, we can proceed with this. @benogle do you need help with it? |
|
Regarding the build...it won't turn green until (probably) Atom 1.11.0. |
|
@50Wliu Yes you're right 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14 and atom/language-html#98
The build will work when the second will be accepted.