Skip to content

Search index not properly updating initial data  #560

Closed
@joepio

Description

@joepio
Member

Our E2E tests are failing on the search tests, namely checking the Welcome to your Atomic-Server search. This should be part of the initial index update, but for some reason isnt.

Some approaches:

  • Perhaps we should just add a 5 sec await, similar to the nested search query
  • Make sure that, on initialization, the search index is ran
  • Make sure that the changes made to Drives are commited, or passed through the mechanism that triggers update resources.

The add_all_resources function isn't called on initialize. We could simply call that, and that would fix the problem. But perhaps we need to ask ourselves: why isn't the search index properly updated? Either populate does not create Commits, or our Commits aren't caught by the CommitMonitor. I can see that .save_locally is used in most populate functions (including set_drive_rights, which sets the Welcome... text), so we are creating commits!

I suppose the Commit Monitor simply doesn't exist yet when we populate the store.

We could invert the order.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @joepio

        Issue actions

          Search index not properly updating initial data · Issue #560 · atomicdata-dev/atomic-server