Fix Subfilter support

[harikt]

Related to #155 .

Support maximum of 2.

<?php
require __DIR__ . '/vendor/autoload.php';
$filter_factory = new \Aura\Filter\FilterFactory();
$filter = $filter_factory->newSubjectFilter();

$filter->validate('id')->is('int');
$filter->validate('url')->is('url');

$user_spec = $filter->subfilter('user'); // add a "SubSpec"
$user_filter = $user_spec->filter();  // Get the "SubSpec" SubjectFilter

$user_filter->validate('given-name')->isNotBlank();
$user_filter->validate('age')->is('int');
$user_filter->validate('gender')->is('strlen', 1);

$data = (object) [];

$result = $filter->apply($data);
$messages = $filter->getFailures()->getMessages();

var_dump($messages);

RESULT :

array(3) {
  ["id"]=>
  array(1) {
    [0]=>
    string(31) "id should have validated as int"
  }
  ["url"]=>
  array(1) {
    [0]=>
    string(32) "url should have validated as url"
  }
  ["user"]=>
  array(3) {
    ["given-name"]=>
    array(1) {
      [0]=>
      string(37) "given-name should not have been blank"
    }
    ["age"]=>
    array(1) {
      [0]=>
      string(32) "age should have validated as int"
    }
    ["gender"]=>
    array(1) {
      [0]=>
      string(41) "gender should have validated as strlen(1)"
    }
  }
}

[harikt]

The original PR was from @jakejohns #131 .

I spend quite sometime to make this happen. There are some glitches. But I am not sure how we can overcome that.

If anyone have better ways we can consider that also.

[harikt]

Anyone else interested in contributing can comment on this PR. I am happy to hear criticims. So no issues for raising the bar.

[harikt]

This is one place I dislike.

[koriym]

Is return void sufficient? The caller does not use the return value.

[harikt]

Earlier it was returning the Failure. As it currently changed this now can return Failure or FailureCollection. ie why return is removed. I will look once again if this returned value has some value inside the caller.

[kenjis]

This method is to add a failure. It seems no return value is needed.

[kenjis]

The implementation looks good to me.