Skip to content

Feature/factory additional/override helpers#55

Merged
harikt merged 1 commit intoauraphp:2.xfrom
jakejohns:feature/factory-add-pass-helpers
Feb 5, 2022
Merged

Feature/factory additional/override helpers#55
harikt merged 1 commit intoauraphp:2.xfrom
jakejohns:feature/factory-add-pass-helpers

Conversation

@jakejohns
Copy link
Copy Markdown
Member

How do people feel about the ability to pass additional/override helpers?

For example:

$my_helpers = [
    'foo' => $di->lazyNew(MyFooHelper::class),
    'url' => $di->lazyGetCall('radar/adr:router', 'newUrlHelper')
];

$Helper_locator_factory->newInstance($my_helpers);

@harikt
Copy link
Copy Markdown
Member

harikt commented Jul 21, 2017

@jakejohns not against passing helpers to factories.

@harikt
Copy link
Copy Markdown
Member

harikt commented Jul 21, 2017

Seems conflicts . Does this PR also contains things from recently merged PR #54 .

@jakejohns jakejohns force-pushed the feature/factory-add-pass-helpers branch 2 times, most recently from 466133e to 828b59c Compare July 21, 2017 07:14
@jakejohns jakejohns mentioned this pull request Jul 21, 2017
@jakejohns
Copy link
Copy Markdown
Member Author

I rebased this branch. It should be happy now.

@harikt
Copy link
Copy Markdown
Member

harikt commented Jul 21, 2017

I am 👍 for this. Lets merge it.

@jakejohns
Copy link
Copy Markdown
Member Author

@harikt if you like it, and @pmjones has no objection, I guess do it !

@harikt harikt merged commit 6c7ff4f into auraphp:2.x Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants