Skip to content

PHP 8 Support #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmjones merged 2 commits into from
Oct 19, 2020
+7 −9
Merged

PHP 8 Support #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
697e3ee
Add PHP 8 test
koriym Oct 7, 2020
34dd974
Avoid phpunit error with PHP 8
koriym Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,16 @@ php:
- 7.4
before_script:
- composer self-update
install:
- composer install
script:
- ./vendor/bin/phpunit --coverage-clover=coverage.clover
after_script:
- wget https://scrutinizer-ci.com/ocular.phar
- php ocular.phar code-coverage:upload --format=php-clover coverage.clover
jobs:
include:
- stage: Test
name: PHP 8
php: nightly
install: composer install --ignore-platform-reqs
9 changes: 0 additions & 9 deletions tests/ExtendedPdoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,15 +508,6 @@ public function testTransactions()

$actual = $this->pdo->fetchAll("SELECT * FROM pdotest");
$this->assertSame(11, count($actual));

return $rollBackResult;
}

/**
* @depends testTransactions
*/
public function testRollBack($rollBackResult)
{
$this->assertTrue($rollBackResult);
}

Expand Down