Compatibility with PHP 8.1#193
Merged
kenjis merged 25 commits intoauraphp:5.xfrom Nov 8, 2021
srjlewis:5.x-php8.1
Merged
Conversation
* allow psr/log v2 widens the restriction for which logger interface to use. similar to how symfony handles this: https://github.com/symfony/console/blob/5.3/composer.json#L34
# Conflicts: # composer.json
Closed
Member
|
@koriym Can you review? |
kenjis
reviewed
Nov 3, 2021
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
reviewed
Nov 3, 2021
Co-authored-by: kenjis <kenji.uui@gmail.com>
By default PDO now uses native types for int/floats instead of everything being strings.
koriym
approved these changes
Nov 4, 2021
…ctionNotFound from getDefault() on a null default
srjlewis
commented
Nov 4, 2021
Contributor
Author
srjlewis
left a comment
srjlewis
left a comment
There was a problem hiding this comment.
Add a extra test, all looks good
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
reviewed
Nov 7, 2021
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
kenjis
reviewed
Nov 7, 2021
Member
|
Could you update the config file of PHPUnit? |
Member
|
We tried to match the PDO method signatures in the PHP manual as much as possible. |
Member
|
@srjlewis Thank you! |
Merged
Member
|
Close #192 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typing and compatibility with PHP 8.1
I have also pulled in #191