Skip to content

Enable PHP 7.2-8.1 compat#202

Merged
kenjis merged 6 commits intoauraphp:4.xfrom
iansltx:4.x
Nov 24, 2021
Merged

Enable PHP 7.2-8.1 compat#202
kenjis merged 6 commits intoauraphp:4.xfrom
iansltx:4.x

Conversation

@iansltx
Copy link
Copy Markdown
Contributor

@iansltx iansltx commented Nov 13, 2021

No description provided.

@koriym koriym self-requested a review November 13, 2021 02:59
Comment thread src/AbstractExtendedPdo.php
Comment thread src/AbstractExtendedPdo.php
@iansltx
Copy link
Copy Markdown
Contributor Author

iansltx commented Nov 23, 2021

Bumping this as I believe all feedback has been responded to.

@kenjis
Copy link
Copy Markdown
Member

kenjis commented Nov 24, 2021

On PHP 7.3 and 7.4

There was 1 error:

1) Aura\Sql\ConnectionLocatorTest::testNullDefault
Declaration of Aura\Sql\AbstractExtendedPdo::prepare($query, array $options = Array): PDOStatement should be compatible with PDO::prepare($statement, $options = NULL)

/home/runner/work/Aura.Sql/Aura.Sql/src/AbstractExtendedPdo.php:26
/home/runner/work/Aura.Sql/Aura.Sql/src/ExtendedPdo.php:22
/home/runner/work/Aura.Sql/Aura.Sql/tests/ConnectionLocatorTest.php:24

@kenjis kenjis merged commit 995db7a into auraphp:4.x Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants