Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Update dependencies and remove babel.js usage #60

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Update dependencies and remove babel.js usage #60

merged 4 commits into from
Aug 31, 2020

Conversation

radekk
Copy link
Contributor

@radekk radekk commented Aug 31, 2020

This PR removes all known vulnerabilities in dependencies.

  • Updating all packages to the latest version.
  • Removing Babel and upgrading webpack to v4.

radekk added 3 commits August 28, 2020 12:53
Updating webpack to the latest version as well as removing Babel that is not needed anymore.
@radekk radekk added enhancement dependencies Pull requests that update a dependency file labels Aug 31, 2020
@radekk radekk requested a review from a team as a code owner August 31, 2020 14:57
@radekk radekk mentioned this pull request Aug 31, 2020
@@ -5,6 +5,7 @@ const webpack = require('webpack');
const distPath = path.join(__dirname, '../dist');

const config = {
mode: 'production',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what does this mode mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this configuration it doesn't do anything. It's just required by webpack itself (config linting). It could be used to change the default behavior/config but requires an additional code that was not added here.

Copy link

@esarafianou esarafianou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekk radekk merged commit 62ec285 into master Aug 31, 2020
@radekk radekk deleted the webpack branch August 31, 2020 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants