Skip to content

feat: Add support for Wordpress 'reauth' #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

PeterGFernandez
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

  1. Change to support Wordpress reauth as described here (please note that I'm making reference to the description of reauth and not any other context provided in that thread).
  2. supplemental and supporting change to remove the check in the Auth0 callback to detect if a user already has a valid Wordpress login. Primarily in support of 1 (above), but also because best-practice should be that all valid checking really ought to be performed in the Auth0 callback and not subverted by any notional local state.

Testing

Testing has been performed against the lastest available download of the plugin on Wordpress.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@PeterGFernandez PeterGFernandez requested a review from a team as a code owner August 21, 2023 14:08
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@evansims evansims merged commit 84152fa into auth0:4.x Aug 21, 2023
@PeterGFernandez PeterGFernandez deleted the 4.x_reauth_support branch August 21, 2023 16:01
PeterGFernandez added a commit to PeterGFernandez/wordpress that referenced this pull request Aug 21, 2023
Added support for Wordpress 'reauth' (auth0#877)
@evansims evansims changed the title Added support for Wordpress 'reauth' feat: Add support for Wordpress 'reauth' Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants