Skip to content

Compile on stable Rust 2018 #13

Closed
Closed
@LukasKalbertodt

Description

@LukasKalbertodt
Member

It would be neat to be able to use this on stable (once use_extern_macros is stabilized). Currently the following features are activated:

  • #![feature(in_band_lifetimes)]: tracking issue, expected to be stabilized for Rust 2018. If not, we can easily remove the feature by changing one line of code. => probably won't be stabilized, so this has been removed from this crate for now.
    #![feature(proc_macro_span)]: used only for one Span::join() call. I think it's easy to remove join() with something we can use on stable. => guarded by nightly feature (see Guard unstable proc_macro things behind nightly feature #26)
    #![feature(proc_macro_diagnostic)]: this is the big part! I don't think the Diagnostics API will be stabilized in near future. So in order to compile on stable, we need to replace all nice diagnostics with simple panics. This shouldn't be too hard. => guarded by nightly feature (see Guard unstable proc_macro things behind nightly feature #26)

We still use Cargo's cargo-features = ["edition"] (EDIT: it's stabilized on nightly and beta RC1 now) with edition ="2018" which entails a couple of features. But all of these should be stabilized for Rust 2018 (EDIT: they are now).

Activity

added this to the v0.3 milestone on Jul 20, 2018
Mark-Simulacrum

Mark-Simulacrum commented on Jul 20, 2018

@Mark-Simulacrum

replace all nice diagnostics with simple panics.

I would instead use the compile_error macro -- that'll give you slightly nicer error messages and it is already stable.

LukasKalbertodt

LukasKalbertodt commented on Jul 20, 2018

@LukasKalbertodt
MemberAuthor

@Mark-Simulacrum Awesome idea! I'll certainly try that!

removed this from the v0.3 milestone on Aug 30, 2018
LukasKalbertodt

LukasKalbertodt commented on Aug 30, 2018

@LukasKalbertodt
MemberAuthor

I think we should release a new version before the official Rust 2018 release. So I removed the v0.3 milestone.

LukasKalbertodt

LukasKalbertodt commented on Sep 21, 2018

@LukasKalbertodt
MemberAuthor

With #31 this crate compiles on beta RC1. So we're on track for having this compile on stable Rust 2018. I guess we'll keep this issue open until the real Rust 2018 is released and we can be sure that all is fine.

EDIT: Also compiles with rustc 1.31.0-beta.1 (2824a67b0 2018-10-29)
EDIT2: Also compiles with rustc 1.31.0-beta.19 (42053f9f0 2018-11-26)

LukasKalbertodt

LukasKalbertodt commented on Dec 6, 2018

@LukasKalbertodt
MemberAuthor

Seems to work with Rust 2018 (1.31), so I'm gonna close this :)

Happy Rust2018!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Mark-Simulacrum@LukasKalbertodt

        Issue actions

          Compile on stable Rust 2018 · Issue #13 · auto-impl-rs/auto_impl