Skip to content

Remove unused meteredHandler struct type #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Remove unused meteredHandler struct type #3450

merged 1 commit into from
Oct 9, 2024

Conversation

joshua-kim
Copy link
Contributor

@joshua-kim joshua-kim commented Oct 9, 2024

Why this should be merged

The metrics instance is never used, we emit all metrics from the router struct. I vaguely recall this being used previously (?) so my guess is that we did a refactor and forgot to delete this (ref).

How this works

Removes struct definition

How this was tested

UT

Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim joshua-kim marked this pull request as ready for review October 9, 2024 15:16
@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Oct 9, 2024
@StephenButtolph StephenButtolph added this to the v1.11.12 milestone Oct 9, 2024
@joshua-kim joshua-kim enabled auto-merge October 9, 2024 15:36
@joshua-kim joshua-kim added this pull request to the merge queue Oct 9, 2024
Merged via the queue into master with commit d2e9d12 Oct 9, 2024
23 checks passed
@joshua-kim joshua-kim deleted the p2p-metrics branch October 9, 2024 15:55
yacovm pushed a commit to yacovm/avalanchego that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants