database: add applicable dbtests for linkeddb #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Oct 21, 2024
Signed-off-by: Darioush Jalali <[email protected]>
added 2 commits
October 22, 2024 10:18
StephenButtolph
approved these changes
Oct 22, 2024
marun
approved these changes
Oct 23, 2024
yacovm
pushed a commit
to yacovm/avalanchego
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Darioush Jalali <[email protected]>
yacovm
pushed a commit
to yacovm/avalanchego
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Darioush Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Improves test coverage and fixes an edge case in linkeddb.
How this works
Splits the database tests into TestsBasic and Tests, where TestsBasic can run only with a KeyValueReaderWriterDeleter.
Note linkeddb doesn't really implement the interface for Iteratee, as the iteration is not guaranteed to be ordered.
Adds a key modification step to TestMemorySafetyDatabase which would have identified this edge case as the fuzzer does not seem to find it.
How this was tested
CI