ACP-77: Allow legacy validator removal after conversion #3521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
reviewed
Nov 5, 2024
| e.Bootstrapped.Set(true) | ||
| return env.unsignedTx, e | ||
| }, | ||
| expectedErr: ErrRemoveValidatorManagedSubnet, |
There was a problem hiding this comment.
Is it possible to retain the test with expectedErr as nil instead?
There was a problem hiding this comment.
The first test in the vector was modified to do this
ceyonur
approved these changes
Nov 5, 2024
marun
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ACP-77 was updated to allow removal of legacy subnet validators after the conversion.
How this works
Removes the checks.
How this was tested
updates the test
Need to be documented in RELEASES.md?
No.