Skip to content

docs: Fix grammatical errors and improve clarity in documentation and comments #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 16, 2025

Conversation

VolodymyrBg
Copy link
Contributor

Why this should be merged

This PR fixes grammatical errors in comments and documentation, improving clarity and readability. It replaces instances of "iff" with "if" and refines several explanations to be more precise.

How this works

The changes update inline comments and documentation across multiple files (db.go, key.go, node.go, and proof.go). These modifications ensure that the text is grammatically correct without altering functionality.

How this was tested

Since this PR only modifies comments and documentation, no functional testing is required. However, a thorough review was performed to ensure correctness and consistency in the wording.

Need to be documented in RELEASES.md?

No, as this PR does not introduce any functional changes.

Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Copy link
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iff is common mathematical shorthand for if and only if.

I think the fixes other than the x/merkledb/README.md should be reverted.

@VolodymyrBg
Copy link
Contributor Author

iff is common mathematical shorthand for if and only if.

I think the fixes other than the x/merkledb/README.md should be reverted.

Sorry I didn't know about iff, I'm gonna correct it right now

Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
Signed-off-by: VolodymyrBg <[email protected]>
@VolodymyrBg
Copy link
Contributor Author

@StephenButtolph Corrected

@VolodymyrBg
Copy link
Contributor Author

@StephenButtolph Im glad that i was useful, could you merge it, please?

@StephenButtolph StephenButtolph added this pull request to the merge queue Feb 16, 2025
Merged via the queue into ava-labs:master with commit d76684b Feb 16, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants