[tmpnet] Avoid port forwarding when running in a kube cluster #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously port forwarding was always used to communicate with a node even when a test workload was running inside a kube cluster (assumed to be the same cluster hosting the avalanchego nodes). Now the pod IP will be used if running in a kube cluster (as indicated by a service account token is observed on the local filesystem). This avoids the overhead of tunneling through the kube API when not needed.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the application connects to nodes when running within a Kubernetes cluster by using the pod's direct IP and staking address, thereby avoiding unnecessary port forwarding.
- Replaced TODO comments with logic to use direct pod URIs in GetLocalURI and GetLocalStakingAddress when running in-cluster.
- Introduced a new helper function, isRunningInCluster, to determine if the test is running inside a Kubernetes cluster.
RodrigoVillar
approved these changes
Jun 5, 2025
yacovm
approved these changes
Jun 5, 2025
|
whoops, jumped the 🔫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously port forwarding was always used to communicate with a node even when a test workload was running inside a kube cluster (assumed to be the same cluster hosting the avalanchego nodes). Now the pod IP will be used if running in a kube cluster (as indicated by a service account token is observed on the local filesystem). This avoids the overhead of tunneling through the kube API when not needed.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A