chore: upgrade to node 20 #3250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Apr 8, 2025
| > If you are using Yarn v2, run `yarn set version classic` to change to Yarn Classic. | ||
| > | ||
| > Note: Ensure that the version of Node installed is v18.x. During the installation process, some modules may not be compatible with other versions of Node. | ||
| > Note: Ensure that the version of Node installed is v20.x. During the installation process, some modules may not be compatible with other versions of Node. |
Contributor
There was a problem hiding this comment.
we went for 22.x on cli side. we should align on that line.
Contributor
There was a problem hiding this comment.
ah, this is gen2. plz disregard.
sobolk
approved these changes
Apr 8, 2025
svidgen
approved these changes
Apr 8, 2025
dpilch
pushed a commit
that referenced
this pull request
Apr 8, 2025
dpilch
pushed a commit
that referenced
this pull request
Apr 9, 2025
dpilch
pushed a commit
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.