Skip to content

Conversation

@sobolk
Copy link
Contributor

@sobolk sobolk commented May 14, 2025

Description of changes

Skip Location in directive arguments cloning.

For large schemas attempt to clone Location leads to Maximum call stack size exceeded error.

Location in AST nodes is read only artifact from schema parsing, therefore safe for skipping.

Issue #, if available

Fixes. #3274

Description of how you validated changes

  1. Added test.
  2. Validated in repro app.

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk marked this pull request as ready for review May 14, 2025 18:36
@sobolk sobolk requested a review from a team as a code owner May 14, 2025 18:36
@sobolk sobolk merged commit 06fec17 into aws-amplify:main May 14, 2025
7 of 8 checks passed
@sobolk sobolk deleted the fix-deep-clone branch May 14, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants