Updates @aws-sdk/types to same version as in Gen2 CLI
#3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCat567
changed the title
@aws-sdk/types to same version as Gen2 CLI
ShadowCat567
changed the title
@aws-sdk/types to same version as Gen2 CLI@aws-sdk/types to same version as in Gen2 CLI
Amplifiyer
previously approved these changes
Jun 13, 2025
svidgen
previously approved these changes
Jun 13, 2025
sobolk
reviewed
Jun 13, 2025
| "@aws-sdk/region-config-resolver": "3.614.0", | ||
| "@aws-sdk/token-providers": "3.614.0", | ||
| "@aws-sdk/types": "3.609.0", | ||
| "@aws-sdk/types": "3.734.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "@aws-sdk/types": "3.734.0", | |
| "@aws-sdk/types": "^3.734.0", |
So that we don't have to do it again in the future.
this should be ok for types package.
| "@aws-sdk/token-providers": "3.614.0", | ||
| "@aws-sdk/types": "3.609.0", | ||
| "@aws-sdk/util-endpoints": "3.637.0", | ||
| "@aws-sdk/types": "3.734.0", |
Contributor
There was a problem hiding this comment.
Suggested change
| "@aws-sdk/types": "3.734.0", | |
| "@aws-sdk/types": "^3.734.0", |
So that we don't have to do it again in the future.
this should be ok for types package.
sobolk
approved these changes
Jun 13, 2025
svidgen
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upgrades
@aws-sdk/typesto the same version Amplify CLI Gen2 uses. Tried to upgrade other@aws-sdkpackages to the same version as Gen2 CLI but the e2e tests really did not like that.Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.