Feat: Update Gen1 Data to be compatible with SDK v2->V3 migrations happening in Gen1 CLI #3310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
added 3 commits
June 19, 2025 15:06
added 16 commits
September 5, 2025 10:59
ShadowCat567
changed the title
svidgen
previously approved these changes
Sep 16, 2025
6 tasks
svidgen
approved these changes
Sep 23, 2025
mrgrain
pushed a commit
that referenced
this pull request
Sep 25, 2025
…ppening in Gen1 CLI (#3310) * fix: remove global config * chore: update api * v1.0.0 * Revert "v1.0.0" This reverts commit 1aca077. * fix: ssmclient can use v1 or v2 * chore: add ssm-client * chore: update dep license * fix: update expected error message * chore: update node types * chore: update node type for client-test-app * chore: update jest to handle node: imports * chore: upgrade jest * chore: licenses * Revert "chore: licenses" This reverts commit 8e43f0e. * Revert "chore: upgrade jest" This reverts commit fa3dc3d. * chore: change client-ssm version * chore: license * chore: update yarn lock * chore: remove workaround * fix: unit tests and better way of identifing v3 client * chore: license * chore: update v3 Client detection * fix: search for other acc for FunctionTransformerV2 test like main does --------- Co-authored-by: aws-amplify-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Gen1 CLI pushed some breaking changes when it released with the first SDK V2->V3 PR. This should update data to match those changes.
CLI PR: aws-amplify/amplify-cli#14199
This also updates the SSMClient we use from Gen1 CLI to be able to consume either a V2 or V3 style client, the V2 part should be removed in favor of the V3 client when this Gen1 CLI PR gets released (aws-amplify/amplify-cli#14238), but this allows us to operate with either while waiting for Gen1 CLI to release its changes.
Note: I used
sendto tell whether we are dealing with a V2 or a V3 client because V2 clients don't have send functions.Unrelated to SDK Migrations
For some reason
@types/nodewas set to Node 12 for a lot of thepackage.jsonfiles in this repo this includes an update that bumps them all to Node 18 because that is the version that is the best supported by this repo even though it was allegedly upgraded to Node 20.Fixes
FunctionTransformerTestsV2. PreviouslyFunctionTransformertest would take the first account it found and use it asotheraccount. In a lot of cases this would be the account that is currently being used to run the test and would cause the test to fail. Added a check to ensure thatotheraccountis not getting set to the account that is being used to run the test. -- this change was applied to Gen2 but it was never retroactively added to Gen1.Issue #, if available N/A
Description of how you validated changes
Validated that the command
amplify api add-graphql-datasourcestill works (as much as it can)Validated that e2e tests still work properly in Gen1 CLI by running e2es on the SDK migrations branch that needs these changes and a branch that was based on
devwith the only change being that it uses this PR's tag release as its@aws-amplify/amplify-category-apiversion.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.